dependencies check are now required to merge ci#21940
Merged
blaginin merged 1 commit intoapache:mainfrom Apr 29, 2026
Merged
Conversation
blaginin
commented
Apr 29, 2026
Comment on lines
-28
to
-34
| paths: | ||
| - "**/Cargo.toml" | ||
| - "**/Cargo.lock" | ||
| pull_request: | ||
| paths: | ||
| - "**/Cargo.toml" | ||
| - "**/Cargo.lock" |
Member
Author
There was a problem hiding this comment.
if action is required it has to be run always
blaginin
commented
Apr 29, 2026
| jobs: | ||
| depcheck: | ||
| name: circular dependency check | ||
| name: Circular Dependency Check |
Member
Author
There was a problem hiding this comment.
sadly, if this PR is merged, every other PR will have to pull latest main in order to be merged..
Contributor
There was a problem hiding this comment.
I think that is ok -- we can merge to main and then add to the merge queue and then it will get merged eventually
github-actions
Bot
added
the
development-process
Contributor
|
Yeah I suppose let's run it and then optimize CI resources if we get yelled at. Thanks @blaginin -- let's give it atry |
alamb
approved these changes
Apr 29, 2026
Member
Author
|
Seems to be working - Just merged develop into #21907 to test |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #21938 (comment)
I feel like this is quite a useful check - and it's relatively small - let's run it always?