IGNITE-28462: Upgrade remaining Maven plugins#12982
Open
animovscw wants to merge 11 commits intoapache:masterfrom
Open
IGNITE-28462: Upgrade remaining Maven plugins#12982animovscw wants to merge 11 commits intoapache:masterfrom
animovscw wants to merge 11 commits intoapache:masterfrom
Conversation
animovscw
changed the title
animovscw
force-pushed
the
ignite-28462
branch
3 times, most recently
from
812a406 to
724521a
Compare
zstan
reviewed
Apr 16, 2026
animovscw
force-pushed
the
ignite-28462
branch
2 times, most recently
from
c9de64f to
8217e35
Compare
zstan
reviewed
Apr 28, 2026
|
|
||
| if (file.isFile() && fileName.toLowerCase().endsWith(".class")) | ||
| if (file.isFile() && fileName.toLowerCase().endsWith(".class") | ||
| && !fileName.equals("package-info.class")) |
Contributor
There was a problem hiding this comment.
can you append a comment, why we need such a change plz ?
Contributor
Author
There was a problem hiding this comment.
Plugin update revealed that there was a defect in BinaryContext .
After the version was upgraded package-info.class became physically present in the package directory on the disk. The method picked it up as a regular class and added it to the list for registration as a binary type.
Logs: https://ci2.ignite.apache.org/buildConfiguration/IgniteTests24Java8_BinaryObjects/9015329?buildTab=overview
Previous keystore used 1024-bit DSA key expired in 2007. maven-jarsigner-plugin 3.1.0 enforces strict validation and rejects signing with weak/expired certificates. Replaced with RSA 2048-bit key valid for 10 years.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
The Contribution Checklist
The description explains WHAT and WHY was made instead of HOW.
The following pattern must be used:
IGNITE-XXXX Change summarywhereXXXX- number of JIRA issue.(see the Maintainers list)
the
green visaattached to the JIRA ticket (see tabPR Checkat TC.Bot - Instance 1 or TC.Bot - Instance 2)Notes
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.