[WIP] DO NOT MERGE!!!! - Springboot 4.0.x upgrade #6686
Draft
nrknithin wants to merge 6 commits intoapache:mainfrom
Draft
[WIP] DO NOT MERGE!!!! - Springboot 4.0.x upgrade #6686nrknithin wants to merge 6 commits intoapache:mainfrom
nrknithin wants to merge 6 commits intoapache:mainfrom
Conversation
927c2f3 to
ffe45fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kie-Issue: apache/incubator-kie-issues#2288
Related PRs
Summary
Update version properties in
build-parent/pom.xmlto align with Spring Boot 4.0.x. Drools doesn't depend on Spring Boot directly, but downstream Apache KIE repos (kogito-runtimes,kogito-apps,kogito-examples) inherit these versions, so they need to match thespring-boot-dependencies:4.0.5BOM.What changed
jackson
2.21.1→2.21.2jackson.databind
2.21.1→2.21.2micrometer
1.14.12→1.16.4hamcrest
2.2→3.0junit-jupiter
5.13.4→6.0.3junit-platform
1.13.4→6.0.3(JUnit 6 uses unified versioning)logback
1.5.25→1.5.32h2database
2.3.232→2.4.240commons-lang3
3.18.0→3.19.0infinispan
15.0.21.Final→15.2.6.Finalpostgresql
42.7.8→42.7.10Why
Spring Boot 4.0.5 ships these versions in its dependencies BOM. Aligning here prevents version-resolution conflicts in downstream repos that import both
drools-build-parentandspring-boot-dependencies.One subtle point: junit-platform had to go to
6.0.3, not1.14.x. JUnit 6 unified the version numbering —junit-bom:6.0.3pins both Jupiter and Platform to 6.0.3. Pairing Jupiter6.0.3with Platform1.13.4causesNoSuchMethodErrorat test discovery.Verified with a full
mvn clean install(all tests pass).In
drools-reliability/drools-reliability-infinispan/pom.xml&drools-reliability/drools-reliability-tests/pom.xml: added an<ignoreClass>entry fororg.infinispan.commons.spi.OffHeapMemoryandThreadCreator(scoped toinfinispan-commons-spi) to resolve a CI duplicate-class build failure introduced by the infinispan bump — at15.2.6.Finalupstream ships byte-identical copies of those two classes in bothinfinispan-commonsandinfinispan-commons-spi. Mirrors the existinginfinispan-objectfilterexception in the same file.