MINOR: Simplify AlterPartitionManager request building and tests#22589
Open
joshua2519 wants to merge 1 commit into
Open
MINOR: Simplify AlterPartitionManager request building and tests#22589joshua2519 wants to merge 1 commit into
joshua2519 wants to merge 1 commit into
Conversation
- buildRequest: replace groupingBy with single-pass find-or-create map - drop duplicated CLUSTER_AUTHORIZATION_FAILED message literal - test: use TopicIdPartition instead of a custom key record
github-actions
Bot
added
triage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #21432 addressing review feedback:
buildRequest: replaceCollectors.groupingBywith a single-pass find-or-create over a localMap<Uuid, TopicData>, avoiding the intermediateMap<Uuid, List<AlterPartitionItem>>.handleAlterPartitionResponse: factor theCLUSTER_AUTHORIZATION_FAILEDmessage into a local to drop the duplicated string literal.AlterPartitionManagerTest: drop the redundantTopicPartitionKeyrecord in favor ofTopicIdPartition.