[QPIDJMS-624] Also support non-byte type-annotations#61
Open
davidvoit wants to merge 1 commit into
Open
Conversation
Contributor
|
A JIRA should be opened for this at https://issues.apache.org/jira/projects/QPIDJMS/ and the commit updated to reference the JIRA |
tabish121
reviewed
Jun 2, 2026
davidvoit
changed the title
NMS AMQP is using "byte" which are unsigned in dotnet. Yes, this is non-std compatible, but not handling these values is also non-std compatible. It's a MUST to sent data as signed byte. But it's also a MUST to read other numeric values in the type-annotations fields in the binding spec.
Author
|
@tabish121 do you need some other changes here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NMS AMQP is using "byte" which are unsigned in dotnet. Yes, this is non-std compatible, but not handling these values is also non-std compatible.
It's a MUST to sent data as signed byte.
But it's also a MUST to read other numeric values in the type-annotations fields in the binding spec.
This is related to apache/activemq-nms-amqp#101