Bump kafka-clients to 3.9.1 to fix SASL auth failure on JDK 24+ (#13849)#13859
Open
NamanKu-tech wants to merge 1 commit intoapache:masterfrom
Open
Bump kafka-clients to 3.9.1 to fix SASL auth failure on JDK 24+ (#13849)#13859NamanKu-tech wants to merge 1 commit intoapache:masterfrom
NamanKu-tech wants to merge 1 commit intoapache:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the OAP Server BOM-managed Kafka client dependency to address SASL authentication failures when running on JDK 24+ (related to JEP 486 / KAFKA-18866 behavior changes).
Changes:
- Bump
org.apache.kafka:kafka-clientsfrom3.4.0to3.9.1inoap-server-bom. - Document the dependency bump and rationale in the 10.5.0 changelog.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
oap-server-bom/pom.xml |
Updates the BOM property to use kafka-clients 3.9.1. |
docs/en/changes/changes.md |
Adds a 10.5.0 changelog entry explaining the Kafka client bump and JDK 24+ SASL impact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| #### Project | ||
|
|
||
| * Bump `kafka-clients` from 3.4.0 to 3.9.1 to fix SASL authentication failure on JDK 24+ (JEP 486 removed `Subject.getSubject`; fix included in kafka-clients 3.9.1 via KAFKA-17078). |
Member
|
You should update the license file. And e2e don't have e2e to verify this, so, we are not sure the dependency upgrade, but the compatibility is uncertain. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #13849: kafka-clients SASL authentication failure on JDK 24+
JDK 24 permanently disabled
Subject.getSubject(AccessControlContext)(JEP 486, see KAFKA-18866).kafka-clients 3.4.0calls this method during SASL authentication, causing OAP to crashat startup when
kafka-fetcheris configured with a SASL security protocol.Bumping to
kafka-clients 3.9.1which includes KAFKA-17078 — a reflective shim thatdispatches between
Subject.callAs/current(JDK 18+) andSubject.doAs/getSubject(JDK 11-17),making it work on JDK 11 through 25 with a single jar.
CHANGESlog.signed by: namanworkie@gmail.com