Add prometheus retention config#1
Open
aaronbee wants to merge 1 commit intoarista-netdevops-community:mainfrom
Open
Add prometheus retention config#1aaronbee wants to merge 1 commit intoarista-netdevops-community:mainfrom
aaronbee wants to merge 1 commit intoarista-netdevops-community:mainfrom
Conversation
Without a retention time or size flag prometheus defaults to deleting any data older than 15d. The data we are using to debug can be older than 15d, so prometheus will delete it when it starts up.
ciacono
approved these changes
May 3, 2024
alexaliu
reviewed
May 22, 2024
| - '--storage.tsdb.path=/prometheus' | ||
| - '--web.console.libraries=/usr/share/prometheus/console_libraries' | ||
| - '--web.console.templates=/usr/share/prometheus/consoles' | ||
| - '--storage.tsdb.retention.size=1TB' |
There was a problem hiding this comment.
I don't think we want the size, should be the time. --storage.tsdb.retention.time=1y
Contributor
Author
There was a problem hiding this comment.
I preferred limiting retention on size, so we can still look at data from a year ago. It seems more likely the retention would kick in on time vs. size. We could set time to be 100 years and then not worry about it, but that's also what a size of 1TB achieves I think.
There was a problem hiding this comment.
Oh I see, does this work correctly? I expected the default 15d retention to still kick in.
Contributor
Author
There was a problem hiding this comment.
Yeah, if either retention.size or retention.time is set then the default 15d retention is ignored.
alexaliu
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without a retention time or size flag prometheus defaults to deleting any data older than 15d. The data we are using to debug can be older than 15d, so prometheus will delete it when it starts up.