Qualify encoder fields with this. to avoid clashes#560
Open
writeoncereadmany wants to merge 1 commit intoartiofix:masterfrom
Open
Qualify encoder fields with this. to avoid clashes#560writeoncereadmany wants to merge 1 commit intoartiofix:masterfrom
writeoncereadmany wants to merge 1 commit intoartiofix:masterfrom
Conversation
(cherry picked from commit 4cf9658)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some cases recently where the generated encoders were failing to compile because we had a field called value (the same could happen with fields named offset or length, which are less likely but possible), where the generated encoder was shadowing the field with method parameters.
We can resolve this by qualifying field access with
this, which only increases clarity and disambiguates the reference - this change includes at least as many as required to permit us to compile with the field names.