Bugfix - https://github.com/aws-samples/amazon-ecr-replication-for-pu…

[NxP4Code]

…b-container-images/issues/8

*Issue #8 *
*Description of changes:

1. Fixed buildspec.yml to use correct region parameter name
2. Added logic to use .cn or .com as URL suffix for ECR_DN

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution under the terms of your choice.

[walkley]

Thanks for reporting this issue.

This solutions was initially designed to replicate public container images to AWS China regions, it was not validated with targeting to AWS global regions as ECR has supporting Pull Through Cache for upstream registries such as Docker Hub and Quay. I'd recommend to use ECR Pull Through Cache if it works for your use case, but I would still happy to review and merge your PR for this issue. Thanks for your contribution!

[NxP4Code]

Thank you for looking into this. I didn't know about the through cache feature, and I used this repo to upload the image to the ECR repository. It works well with the small modification I submitted in this pull request. Considering the limitation of pull-through for us-gov regions, I think adding this merge request will improve the support of this sample code.