Skip to content

fix: display only the error message for sql-editor#3174

Open
alecsci wants to merge 5 commits into
azerothcore:masterfrom
alecsci:fix(query-error-display)
Open

fix: display only the error message for sql-editor#3174
alecsci wants to merge 5 commits into
azerothcore:masterfrom
alecsci:fix(query-error-display)

Conversation

@alecsci

@alecsci alecsci commented Nov 20, 2024

Copy link
Copy Markdown
Member

fix #3132

@alecsci alecsci left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the users this is better, for the devs this is worse because we lose the stack-trace, so maybe we should have at the end of the alert message a field for the stack-trace ?

@alecsci alecsci changed the title fix: display only the error message for issue #3132 fix: display only the error message for sql-editor Nov 20, 2024
@TheSCREWEDSoftware

Copy link
Copy Markdown
Contributor

I would say the "stack" error makes more sense if you're in developer/debug mode

@alecsci

alecsci commented Nov 21, 2024

Copy link
Copy Markdown
Member Author

Not sure if it's worth doing that much implementation to hide some technical info.
I would like to keep the error component dumb as possible.

We could show both information, but put first the error message, and then the last field can be the stack trace.
@FrancescoBorzi wdyt?

@Helias

Helias commented Nov 21, 2024

Copy link
Copy Markdown
Member

We could show both but in a separate way, so the user can focus on the error message first and then if it's useful can also read the stack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] - Simplification of SQL Errors

4 participants