Conversation
- I accidentally had the updated Program locally and that was why tests were working for me locally
|
|
There was a problem hiding this comment.
The changed tests in this file fix a bug where id (the Org ID) was AssertPropertyEqual'd at the second parameter of GetManyByOrganizationIdWriteAccessAsync which is actually the user ID.
I haven't yet exactly nailed down why this bug presents itself with .NET 10.
a slim debian variant is no longer available also had to avoid clobbering /etc/environment
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the .NET 8 → .NET 10 framework upgrade across all projects, including target framework bumps, obsolete API migrations ( Code Review Details
Dependency Changes
|
dereknance
requested review from
BTreston,
coroiu,
cyprain-okeke,
enmande and
mimartin12
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
||
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <TargetFramework>net10.0</TargetFramework> |
There was a problem hiding this comment.
🎨 Non-blocking:
Probably just an oversight when these projects got created. Any file that has the TargetFramework updated, should probably be changed to delete the TargetFramework line, so the framework can be picked up via the Directory.BuildProps
There was a problem hiding this comment.
Good call. Maybe that helps reduce the reviewers required for the .NET 12 upgrade 😆
5 participants
🎟️ Tracking
PM-28727
📔 Objective
This PR upgrades from .NET 8 to 10.
I left most dependencies at their current versions so they can go through the usual Renovate process.
Notable Changes
Base64.IsValidenforces canonical padding.IHostBuilderstyle #6843WebHostBuilderis obsoleteX509Certificate2constructors are obsoleteNuGetAuditLeveldefaults tolowwith .NET 10, resulting in any dependency with a known vulnerability to block when runningdotnet restore. I elected to set it tocriticalto only block builds for vulns at that severity, and let the existing Renovate process take care of the rest. ❗ I can be convinced to disable this entirely.System.Text.Json8.0.5 pin removed because package pruning emits NU1510Microsoft.Extensions.Caching.Memory8.0.1 pin removed as Microsoft.Data.SqlClient requires >=9 and was resulting in a package downgradeMicrosoft.AspNetCore.HttpOverrides.IPNetworkandKnownNetworkshave been marked as obsoleteNullReferenceExceptionin.Trim()calls. Added null-conditional operators in property setters inGlobalSettings.csMessagePackfrom 2.x to 3.x. The wire format appears compatible for our use case