[PM-36419] [BEEEP] Add collection management settings to seeder#7576
[PM-36419] [BEEEP] Add collection management settings to seeder#7576
Conversation
| // Org-level admin settings — not plan-gated, safe defaults for seeding | ||
| org.UseAutomaticUserConfirmation = true; | ||
| org.AllowAdminAccessToAllCollectionItems = true; | ||
| org.LimitCollectionCreation = true; | ||
| org.LimitCollectionDeletion = true; | ||
| org.LimitItemDeletion = true; |
There was a problem hiding this comment.
Opinionated change I wanted to call out: it's correct that these are not plan-gated, however they all default to false in production, so omitting them here is a more sensible default. Particularly as we now have overrides you can apply to turn them on if you want. (I've included UseAutomaticUserConfirmation in the overrides as well for completeness.)
I assume nobody is relying on these default values yet but we can discuss if this is expected to cause impact anywhere.
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Reviewed the seeder changes that introduce an Code Review DetailsNo findings. The override pattern is internally consistent (schema, model, CLI, options, step), null-coalescing in |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7576 +/- ##
==========================================
+ Coverage 59.61% 59.62% +0.01%
==========================================
Files 2096 2096
Lines 92580 92580
Branches 8245 8245
==========================================
+ Hits 55190 55200 +10
+ Misses 35437 35427 -10
Partials 1953 1953 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-36419
📔 Objective
Allow control of collection management settings via the seeder. These alter organization/collection behavior significantly and go hand-in-hand with different collection/group assignments to set up a customer's preferred access controls.
I wanted to avoid appending lots of nullable parameters to various methods, so I've created an
OrganizationOverridesbucket to contain them. This should allow for easier modification in in the future as well.📸 Screenshots