[PM-32116] Remove pm-32111-provider-ability-extended-cache logic

[JimmyVo16]

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-32115
https://bitwarden.atlassian.net/browse/PM-32116

📔 Objective

Remove the feature flag and use the new provider cache in place of IApplicationCacheService.cs.

Automation tests and the build pipeline should be sufficient. No manual testing needed.

[github-actions]

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR removes the pm-32111-provider-ability-extended-cache feature flag and migrates all consumers (ProviderService, ProvidersController, EventService) from the routed IApplicationCacheService provider-ability methods to IProviderAbilityCacheService directly. The now-unused provider methods were removed from IApplicationCacheService and FeatureRoutedCacheService, and the corresponding flag-routing tests were deleted. I verified there are no dangling flag references, no remaining callers of the removed interface methods, and that IProviderAbilityCacheService is registered unconditionally in both the shared web service collection and Events/Startup, covering all consuming projects.

Code Review Details

No findings. This is a clean, well-scoped feature-flag removal:

• Flag constant ProviderAbilityExtendedCache removed with no remaining references.
• All consumers migrated to IProviderAbilityCacheService; the removed GetProviderAbilityAsync/GetProviderAbilitiesAsync(ids)/UpsertProviderAbilityAsync/DeleteProviderAbilityAsync methods on IApplicationCacheService have no remaining callers.
• DI registration (AddProviderAbilityCache) is unconditional and present in SharedWeb/ServiceCollectionExtensions and Events/Startup, so all consuming projects resolve the dependency.
• The promoted ExtendedProviderAbilityCacheService was already the flag-enabled path; tests were updated accordingly with no behavioral regression.

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[codecov]

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 61.19%. Comparing base (10169e6) to head (a2ff07a).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...in/AdminConsole/Controllers/ProvidersController.cs	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7838      +/-   ##
==========================================
- Coverage   65.67%   61.19%   -4.48%     
==========================================
  Files        2195     2209      +14     
  Lines       97542    97717     +175     
  Branches     8807     8811       +4     
==========================================
- Hits        64061    59799    -4262     
- Misses      31260    35794    +4534     
+ Partials     2221     2124      -97     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.