Skip to content

[PM-39293] Remove v2 naming from account recovery command#7842

Open
eliykat wants to merge 1 commit into
mainfrom
ac/pm-39293/remove-account-recovery-v2-naming
Open

[PM-39293] Remove v2 naming from account recovery command#7842
eliykat wants to merge 1 commit into
mainfrom
ac/pm-39293/remove-account-recovery-v2-naming

Conversation

@eliykat

@eliykat eliykat commented Jun 19, 2026

Copy link
Copy Markdown
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-39293

📔 Objective

Drop the v2 suffix from the new account recovery command. The old version was already removed when the feature flag was removed.

📸 Screenshots

@eliykat eliykat requested a review from a team as a code owner June 19, 2026 04:28
@eliykat eliykat requested a review from JimmyVo16 June 19, 2026 04:28
@eliykat eliykat added the ai-review Request a Claude code review label Jun 19, 2026
@github-actions

github-actions Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

This PR drops the v2 suffix from the account recovery command now that the old version was removed with its feature flag. It is a mechanical refactor: files move from AccountRecovery/v2/ into AccountRecovery/, the namespace loses its .v2 segment, the AccountRecoveryV2 alias and _adminRecoverAccountCommandV2 field/parameter are renamed, and DI registrations plus tests are updated in lockstep. I verified there are no remaining references to the old v2 namespace, alias, or field name anywhere in the codebase, and all interface/type references resolve correctly.

Code Review Details

No findings. Clean refactor with consistent rename across source, DI registration, and tests.

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.22%. Comparing base (19cb812) to head (ace4a11).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7842   +/-   ##
=======================================
  Coverage   61.22%   61.22%           
=======================================
  Files        2209     2209           
  Lines       97716    97743   +27     
  Branches     8815     8815           
=======================================
+ Hits        59824    59848   +24     
- Misses      35768    35771    +3     
  Partials     2124     2124           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eliykat eliykat enabled auto-merge (squash) June 19, 2026 05:07
@eliykat eliykat changed the title [PM-39293] Remove v2 naming from account recovery dialog [PM-39293] Remove v2 naming from account recovery command Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Request a Claude code review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant