Replaced os path to pathlib#594
Open
sachichakrabarti wants to merge 4 commits into
Open
Conversation
sachichakrabarti
changed the title
sachichakrabarti
changed the title
phiwuu
requested changes
Jun 23, 2026
Comment on lines
+153
to
+156
| output_dir = Path(file_path).parent | ||
|
|
||
| if output_dir != Path("."): | ||
| output_dir.mkdir(parents=True, exist_ok=True) |
Member
There was a problem hiding this comment.
We can simplify this even further, because calling mkdir for the . path is not a problem when exist_ok=True.
Suggested change
| output_dir = Path(file_path).parent | |
| if output_dir != Path("."): | |
| output_dir.mkdir(parents=True, exist_ok=True) | |
| Path(file_path).parent.mkdir(parents=True, exist_ok=True) |
This simplification should increase the branch coverage (if it is covered by tests at all...)
sachichakrabarti
force-pushed
the
internal/replace_ospath_to_pathlib
branch
from
d425358 to
55200e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced os path to pathlib in 3 files