packages: add minios package#944
Conversation
There was a problem hiding this comment.
Not sure if we need this since we're not concerned with network initialisation in minios
There was a problem hiding this comment.
I'm still keep this since this is the one set the fix name for the network interface between the kernel space and user space just in case and we could remove this later if not needed.
There was a problem hiding this comment.
These rules, packages/minios/ephemeral-ebs-storage.rules, and packages/minios/ephemeral-storage.rules can be dropped or atleast modified since we don't expect to setup EBS volumes with the nested hypervisor.
There was a problem hiding this comment.
I don't expect needing to run logdog from inside the nested hypervisor.
| %description | ||
| %{summary}. | ||
|
|
||
| %package -n %{_cross_os}minios-corndog |
There was a problem hiding this comment.
%package corndog will append %{_cross_os}minios- to the package name. Same for certdog and ghostdog
| %description -n %{_cross_os}minios-brush | ||
| %{summary}. | ||
|
|
||
| %package -n %{_cross_os}minios-whippet |
There was a problem hiding this comment.
Missing Requires for whippet
|
|
||
|
|
||
|
|
||
| %package -n %{_cross_os}minios-brush |
| %cargo_build --manifest-path %{_builddir}/sources/Cargo.toml \ | ||
| -p ghostdog \ | ||
| -p corndog \ | ||
| -p certdog \ | ||
| -p brush \ | ||
| -p whippet \ | ||
| %{nil} |
There was a problem hiding this comment.
Instead of rebuilding these sources, can we depend on os-{ghostdog,corndog,etc}?
That way we don't have to build these packages twice
There was a problem hiding this comment.
Great idea. I was debating because that will introduce some dead config/template but I think that should be fine.
There was a problem hiding this comment.
Nit: There's a lot of extra newlines in this file
| # bootconfig snippets. | ||
|
|
||
| # TPM2-related services. | ||
|
|
||
| # TPM2-related drop-ins. |
There was a problem hiding this comment.
These comments can be dropped
There was a problem hiding this comment.
We don't need to include kernel-devel for nested hypervisor
|
|
||
| # Other drop-ins. | ||
| Source93: release-tmpfiles.conf | ||
| Source95: release-systemd-networkd.conf |
There was a problem hiding this comment.
Declared but not present or installed
| Source1101: systemd-resolved-service-env.conf | ||
| Source1102: systemd-networkd-service-env.conf |
There was a problem hiding this comment.
Same. Sources are declared but not present in the package files or installed.
|
forced push to address feedback. A con for reduce the double compilation will be inevitable pull in some died configuration file. |
Add a minimal release package that combines first-party binaries and system configuration into a single package. Includes containerd support, SELinux, filesystem setup, D-Bus (whippet), ghostdog, corndog, certdog, and core systemd configuration. Removes apiserver, settings pipeline, in-place updates, networking, FIPS, TPM, and host containers. Signed-off-by: Jingwei Wang <jweiw@amazon.com>
|
forced pushed to fix the changes forget to add in the previous push. |
Description of changes:
Add a minimal release package that combines first-party binaries and system configuration into a single package. Includes containerd support, SELinux, filesystem setup, D-Bus (whippet), ghostdog, corndog, certdog, and core systemd configuration. Removes apiserver, settings pipeline, in-place updates, networking, FIPS, TPM, and host containers.
In some systemd config and rules there are few things I didn't delete because I'm not sure, but happy to hear any feedback.
Testing done:
test with aws-dev and variant definition is in below
Docker Hello World
systemctl status
overlay mount status
partition
what in private partition
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.