Add [@@deriving qcheck] support in interface files#409
Open
Niols wants to merge 1 commit intoc-cube:mainfrom
Open
Add [@@deriving qcheck] support in interface files#409Niols wants to merge 1 commit intoc-cube:mainfrom
[@@deriving qcheck] support in interface files#409Niols wants to merge 1 commit intoc-cube:mainfrom
Conversation
Register a `sig_type_decl` expander for both `qcheck` and `qcheck2` derivers, so that `[@@deriving qcheck]` in `.mli` files generates val declarations for generators (and arbitraries for QCheck). For example: type 'a t [@@deriving qcheck2] produces: val gen : 'a QCheck2.Gen.t -> 'a t QCheck2.Gen.t Parametrized types are handled by adding one `Gen.t` arrow per type parameter. Sized generator signatures (`gen_*_sized`) are intentionally left out. Closes c-cube#189
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register a
sig_type_declexpander for bothqcheckandqcheck2derivers, so that[@@deriving qcheck]in.mlifiles generates val declarations for generators (and arbitraries for QCheck).For example:
produces:
Parametrized types are handled by adding one
Gen.tarrow per type parameter. Sized generator signatures (gen_*_sized) are intentionally left out.Closes #189
I hope this addresses the concerns raised in #286 — let me know if there is anything you would like to see improved.