[az] Show subnet in multipass zones#4969
Merged
Merged
Conversation
a333d26 to
9c7b53a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4969 +/- ##
==========================================
- Coverage 87.84% 87.84% -0.00%
==========================================
Files 271 271
Lines 14669 14676 +7
==========================================
+ Hits 12884 12890 +6
- Misses 1785 1786 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Availability Zones (“zones”) RPC and CLI output so that multipass zones includes the CIDR subnet associated with each zone, making zones easier to interpret and relate to instance IPs (closes #4968).
Changes:
- Added a
subnetfield to theZoneprotobuf message and populated it in the daemon’szonesRPC response. - Updated CLI formatters (table/json/yaml/csv) to include the subnet in
multipass zonesoutput. - Updated unit tests covering the new field and the updated formatted outputs.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/rpc/multipass.proto |
Adds Zone.subnet to the RPC schema. |
src/daemon/daemon.cpp |
Populates Zone.subnet in the zones RPC reply. |
src/client/cli/formatter/table_formatter.cpp |
Adds a “Subnet” column to table output for zones. |
src/client/cli/formatter/json_formatter.cpp |
Includes subnet in zones JSON output. |
src/client/cli/formatter/yaml_formatter.cpp |
Includes subnet in zones YAML output. |
src/client/cli/formatter/csv_formatter.cpp |
Adds “Subnet” column/value to zones CSV output. |
tests/unit/test_output_formatter.cpp |
Updates formatter expectations for table/json/yaml zones output. |
tests/unit/test_daemon_zones.cpp |
Verifies daemon zones replies include subnet values. |
tests/unit/test_cli_client.cpp |
Updates zones CSV output test to include the subnet column/value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the subnet for AZs into the output of
multipass zones.Related Issue(s)
This closes #4968.
Testing
Updated unit tests for the new output
Manual testing steps:
multipass zonesand look at the outputScreenshots (if applicable)
Checklist