Refactor orchestrator.py#1005
Open
ObedAmpahECS wants to merge 1 commit intomainfrom
Open
Conversation
2c49e41 to
d7dfb56
Compare
d7dfb56 to
8049788
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗣 Description
Refactoring of
orchestrator.pyfor continued longterm sustainability💭 Motivation and context
Closes #934.
As part of a testing initiative ,
orchestrator.pywas refactored to limit the number of local variables and decompose larger functions into smaller and more focused functions.🧪 Testing
pylint scubagoggles/orchestrator.pyinside theScubaGogglesdirectory934-refactor-orchestratorInitial scans produced pylint results below:
Refactoring produced these pylint results:
These results return warnings and not outright failures, so is not failing the pipeline.
✅ Pre-approval checklist
✅ Pre-merge Checklist
Squash and mergebutton.✅ Post-merge Checklist