Skip to content

fix: audit hardening + optimization pass for hermes-mod#2

Open
0xNyk wants to merge 1 commit into
cocktailpeanut:masterfrom
0xNyk:reopen/audit-hardening-2026-03-30
Open

fix: audit hardening + optimization pass for hermes-mod#2
0xNyk wants to merge 1 commit into
cocktailpeanut:masterfrom
0xNyk:reopen/audit-hardening-2026-03-30

Conversation

@0xNyk

@0xNyk 0xNyk commented Mar 30, 2026

Copy link
Copy Markdown

Summary

This PR applies a full audit/fix/optimization pass to Hermes Mod with low-risk, targeted changes.

Backend hardening

  • Make Hermes app/python path resolution cross-platform (macOS/Linux/Windows)
  • Improve environment diagnostics via /api/meta
  • Add built-in skin source metadata (fallback vs hermes-skin-engine)

Performance optimization

  • Add TTL cache for built-in skin loading to avoid repeated Python process spawning

Safety improvements

  • Add max image payload guard for hero generation (6MB)
  • Reject empty image payloads/files in hero image ingestion flows

Pinokio workflow cleanup

  • Speed install/update by using npm install --no-audit --no-fund
  • Ignore accidental root pnpm-lock.yaml churn

Validation

  • node --check app/server.js
  • node --check app/public/app.js
  • API smoke tests for status/meta/save/load/activate flows using isolated HERMES_HOME

Risk

Low. Changes are additive or defensive and scoped to known paths/endpoints.

…ds (#1)

- make Hermes app/python path resolution cross-platform

- cache builtin skin loading to reduce repeated Python exec overhead

- add hero image size/empty validation for API safety

- enrich /api/meta diagnostics

- speed install/update by disabling npm audit/fund prompts

- ignore root pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant