Skip to content

Add CWLParameterContext as a TypedDict#392

Merged
mr-c merged 3 commits into
mainfrom
modernize-types-part-2
Dec 12, 2025
Merged

Add CWLParameterContext as a TypedDict#392
mr-c merged 3 commits into
mainfrom
modernize-types-part-2

Conversation

@GlassOfWhiskey

Copy link
Copy Markdown
Collaborator

This commit further modernizes the CWL type system. It also adds a TypedDict class to represent the CWL parameter context used for expression evaluation.

@mr-c mr-c left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make remove_unused_imports should fix it

GlassOfWhiskey and others added 3 commits December 12, 2025 17:16
This commit further modernizes the CWL type system. It also adds a
`TypedDict` class to represent the CWL parameter context used for
expression evaluation.
@mr-c mr-c force-pushed the modernize-types-part-2 branch from c8dd813 to 342bbea Compare December 12, 2025 16:30
@mr-c mr-c merged commit b9de378 into main Dec 12, 2025
27 checks passed
@mr-c mr-c deleted the modernize-types-part-2 branch December 12, 2025 16:38
@codecov

codecov Bot commented Dec 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 87.87879% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 34.66%. Comparing base (35a6e4a) to head (342bbea).
⚠️ Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
cwl_utils/expression.py 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
+ Coverage   34.64%   34.66%   +0.02%     
==========================================
  Files          30       30              
  Lines       35400    35412      +12     
  Branches     9538     9538              
==========================================
+ Hits        12263    12275      +12     
  Misses      20257    20257              
  Partials     2880     2880              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants