EROPSPT-717: Make retention status nullable and remove fields from entities#210
Open
aleyipsoftwire wants to merge 1 commit into
Open
EROPSPT-717: Make retention status nullable and remove fields from entities#210aleyipsoftwire wants to merge 1 commit into
aleyipsoftwire wants to merge 1 commit into
Conversation
aleyipsoftwire
force-pushed
the
remove-retention-status
branch
from
dc93746 to
c864307
Compare
emisto3
reviewed
Jun 5, 2026
emisto3
left a comment
emisto3
left a comment
Contributor
There was a problem hiding this comment.
Sorry I think this will need to split into 2 releases 😢
Also the 3.65 release is pretty big, please can we do this in 3.66 and 3.67 (and therefore move the pre-release steps)
| xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog | ||
| http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd"> | ||
|
|
||
| <changeSet author="alex.yip@softwire.com" id="0042_EROPSPT-717_remove_unused_columns_from_postal" context="ddl"> |
Contributor
There was a problem hiding this comment.
do we know how big the DB is and how many rows will need to be done? Could this time out?
Contributor
Author
There was a problem hiding this comment.
Postal is about 5 million rows, proxy about 50k, all rows will be affected. Would be easy to run this manually before deploying if you think it's worth it
Contributor
There was a problem hiding this comment.
I think it isn't worth the risk, please can you add it to the pre release steps?
Also do we need to worry about locking the DB?
aleyipsoftwire
force-pushed
the
remove-retention-status
branch
from
c864307 to
ba94ba4
Compare
6 tasks
aleyipsoftwire
changed the title
aleyipsoftwire
force-pushed
the
remove-retention-status
branch
from
ba94ba4 to
e15e939
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
These columns aren't used anywhere, so cleaning them up.
I've added the manual script to delete the columns here: https://mhclgdigital.atlassian.net/wiki/spaces/ED1/pages/932217119/Release+-+EROP+3.65+-+11+06+2026#Pre-release-Instructions
Subsequent PR: #211
Issue ticket number and link
https://mhclgdigital.atlassian.net/browse/EROPSPT-717
Checklist before requesting a review
Tick all those which are done
Replace check box with ❌ if the step is not relevant for this PR