fix: align charged gas with EIP-7623 calldata floor after refunds#1186
fix: align charged gas with EIP-7623 calldata floor after refunds#1186mmsqe wants to merge 4 commits into
Conversation
|
PR author is not in the allowed authors list. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1186 +/- ##
==========================================
- Coverage 66.99% 66.92% -0.07%
==========================================
Files 320 320
Lines 23433 23436 +3
==========================================
- Hits 15698 15685 -13
- Misses 6578 6591 +13
- Partials 1157 1160 +3
🚀 New features to boost your workflow:
|
|
fix looks correct, two nits before merge:
|
aljo242
left a comment
There was a problem hiding this comment.
nosec comment missing explanation; pr description is still the template placeholder.
Description
EIP-7623 requires charged gas to be at least the calldata floor. The check was applied up front but not re-enforced after refunds, letting final amount drop below the floor and diverge from go-ethereum. This clamps
gasUsedup tofloorDataGasafter refunds inApplyMessageWithConfigwhenrules.IsPrague.Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
mainbranch