fix(workflow): prevent concurrent map read/write panic during stream processing#2653
Open
phpoh wants to merge 1 commit intocoze-dev:mainfrom
Open
fix(workflow): prevent concurrent map read/write panic during stream processing#2653phpoh wants to merge 1 commit intocoze-dev:mainfrom
phpoh wants to merge 1 commit intocoze-dev:mainfrom
Conversation
…processing When processing streaming output chunks, the code directly used shared map references without deep copying. This caused "concurrent map iteration and map write" panics when other goroutines were still modifying the original maps during JSON marshaling. Changes: - Remove single-chunk shortcut in buildStreamEndEvent that returned shared map reference directly - Remove single-element shortcuts in ConcatStructuredCallbackOutputs and ConcatStructuredCallbackInputs that returned shared references - Always use ConcatMaps to create deep copies of map data, preventing concurrent access issues This fixes the panic reported in issue coze-dev#2607. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConcatMapsto create deep copies of map dataProblem
When processing streaming output chunks, the code directly used shared map references without deep copying. This caused "concurrent map iteration and map write" panics when other goroutines were still modifying the original maps during JSON marshaling.
The panic occurred in
mustMarshalToStringwhen serializingevent.Outputwhile the original map was still being modified elsewhere.Changes
buildStreamEndEvent: Removed single-chunk shortcut that returned shared map reference directlyConcatStructuredCallbackOutputs: Removed single-element shortcuts for inputList and extraListConcatStructuredCallbackInputs: Removed single-input shortcut and extraList shortcutAll map data is now processed through
ConcatMapswhich creates deep copies, preventing concurrent access issues.Test plan
go build ./domain/workflow/internal/execute/... ./domain/workflow/internal/nodes/...Fixes #2607
🤖 Generated with Claude Code