Skip to content

Feat switch rundown api#2080

Open
alex-Arc wants to merge 2 commits into
masterfrom
feat-switch-rundown-api
Open

Feat switch rundown api#2080
alex-Arc wants to merge 2 commits into
masterfrom
feat-switch-rundown-api

Conversation

@alex-Arc
Copy link
Copy Markdown
Collaborator

@alex-Arc alex-Arc commented May 9, 2026

#2079

unsure what a good naming for the api would be (load or switch or...)
should we make it a nested api, will there be mor actions needed on rundown from the api
should we add a way for the user to see the id in the UI

osc example

/api/rundown/load "abcd"

http example

/api/rundown&load=abcd
/api/rundown/load/abcd

websocket

{"rundown": {"load": "abcd"}}

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 6ee40202-732c-4181-9af7-13c0422d4a77

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat-switch-rundown-api

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@alex-Arc alex-Arc marked this pull request as ready for review May 9, 2026 12:33
@manoge2002
Copy link
Copy Markdown

I think you've already done a great job laying the groundwork.
The rundown ID definitely needs to be visible in the UI when it's used. Otherwise, I'd definitely go with exactly what you've done.

@cpvalente
Copy link
Copy Markdown
Owner

@alex-Arc , we will need to wait with this until the rundown loading code is done

as for API design:

I believe that receiving a title may be too lose of an API, we should stick to rundown IDs, at least for now
Since this is primarily concerning the companion module, we could create a select element that shows all the rundown by title and give users options to load one

Should wait on #2086

@alex-Arc alex-Arc force-pushed the feat-switch-rundown-api branch 2 times, most recently from 23a9dc0 to df5bf7e Compare May 17, 2026 18:57
@alex-Arc alex-Arc force-pushed the feat-switch-rundown-api branch from df5bf7e to 8f56bef Compare May 17, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants