Replace SkiaSharp with SixLabors.ImageSharp#80
Draft
Copilot wants to merge 1 commit into
Draft
Conversation
…e dependencies Agent-Logs-Url: https://github.com/crispthinking/PdqHash/sessions/52ef266a-7d39-4eb8-abee-68dd3a03c6d4 Co-authored-by: corpo-iwillspeak <265613520+corpo-iwillspeak@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
corpo-iwillspeak
April 28, 2026 10:36
View session
Contributor
|
We'd need a good overview of the performance impact of this before merging. I'm tempted to not merge TBH. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SkiaSharp pulls in ~370 MB of native runtime dependencies. ImageSharp is pure managed C# (~2-3 MB).
Changes
SkiaSharp,SkiaSharp.NativeAssets.Linux,FFMpegCore.Extensions.SkiaSharp; addSixLabors.ImageSharp3.1.12PdqHasher.cs: ReplaceSKCodec/SKBitmapdecode+resize pipeline withImage.Load<Rgba32>+Mutate(x => x.Resize(...)). Pixel access viaImage<Rgba32>indexer instead ofSKBitmap.GetPixel()FFMegExtensions.cs: ReplaceSKBitmap.Decode(file)withImage.Load<Rgba32>(file)SkiaSharp.NativeAssets.Linuxfrom test project — no longer neededBreaking API changes
FFMegImageExt.GetSnapshotsFromUri()return type changes fromSKBitmaptoImage<Rgba32>.All existing compliance tests pass with identical hash outputs — the switch is lossless for hash computation.