Skip to content

chore: update GitHub Actions workflow indentation and add .venv to .g… #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbottdev merged 2 commits into from
Aug 28, 2025
+8 −10
Merged

chore: update GitHub Actions workflow indentation and add .venv to .g… #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dfec373
chore: update GitHub Actions workflow indentation and add .venv to .g…
abbottdev-kroll Aug 28, 2025
f513c6d
fix: update test timeout syntax for consistency
abbottdev-kroll Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/typedoc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: Deploy TypeDoc on GitHub pages

on:
push:
branches:
main
push:
branches:
main

env:

Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,3 +28,5 @@ build/
# Misc
.DS_Store
.env

.venv
4 changes: 2 additions & 2 deletions __tests__/unit/main.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
}
// Assert error is unset
expect(error).toBeNull();
}, { timeout: 10000 })
}, 10000)
});

describe('classifyImage function', () => {
it('should classify Steamboat-willie.jpg and return responses (integration smoke test)', async ({expect}) => {

Check failure on line 34 in __tests__/unit/main.test.ts

View workflow job for this annotation

GitHub Actions / build

__tests__/unit/main.test.ts > classifyImage function > should classify Steamboat-willie.jpg and return responses (integration smoke test) 

Error: Test timed out in 120000ms.
If this is a long-running test, pass a timeout value as the last argument or configure it globally with "testTimeout".
 ❯ __tests__/unit/main.test.ts:34:3
// This is a smoke test. You must have a running gRPC server at localhost:50051 for this to pass.
// You may want to mock the gRPC client for true unit testing.
const imagePath = __dirname + '/Steamboat-willie.jpg';
Expand Down Expand Up @@ -90,5 +90,5 @@

// Accept either a successful call or a connection error (for CI/dev convenience)
expect(error).toBeUndefined();
}, { timeout: 120000 });
}, 120000);
});
2 changes: 1 addition & 1 deletion eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import tseslint from 'typescript-eslint';
// You should change it to your needs following the documentation.
export default tseslint.config(
{
ignores: ['**/build/**', '**/__tests__/**', '**/tmp/**', '**/coverage/**', 'src/athena/**'],
ignores: ['**/build/**', '.venv/**', '**/__tests__/**', '**/tmp/**', '**/coverage/**', 'src/athena/**'],
},
eslint.configs.recommended,
eslintConfigPrettier,
Expand Down
4 changes: 0 additions & 4 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ import {
} from './authenticationManager';
import { computeHashesFromStream } from './hashing';


/**
* Options for the classifyImage method.
* @property affiliate Optional affiliate identifier for the request.
Expand All @@ -41,7 +40,6 @@ export interface ClassifyImageOptions {
format?: ClassifyRequest['inputs'][number]['format'];
}


/**
* Options for initializing the ClassifierSdk helper.
* @property keepAliveInterval Optional interval (ms) for keep-alive pings.
Expand All @@ -58,7 +56,6 @@ export interface ClassifierHelperOptions {
authentication: AuthenticationOptions;
}


/**
* Event types emitted by the ClassifierSdk.
* @property error Emitted when an error occurs.
Expand All @@ -77,7 +74,6 @@ export type ClassifierEvents = {
export const defaultGrpcAddress =
'csam-classification-messages.crispdev.com:443';


/**
* SDK for interacting with the Athena classification service via gRPC.
* Emits events for data, errors, open, and close.
Expand Down
Loading