Skip to content

Added tag filtering and speedup#88

Open
edurdevic wants to merge 10 commits into
masterfrom
speedup
Open

Added tag filtering and speedup#88
edurdevic wants to merge 10 commits into
masterfrom
speedup

Conversation

@edurdevic

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

CLAassistant commented Nov 27, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

Comment thread discoverx/dx.py Outdated
@codecov

codecov Bot commented Jan 9, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 76.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.40%. Comparing base (dfc9c3f) to head (511f7c9).
⚠️ Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
discoverx/explorer.py 50.00% 4 Missing ⚠️
discoverx/table_info.py 87.50% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
- Coverage   92.90%   92.40%   -0.51%     
==========================================
  Files          11       11              
  Lines         874      895      +21     
  Branches      151      158       +7     
==========================================
+ Hits          812      827      +15     
- Misses         34       39       +5     
- Partials       28       29       +1     
Flag Coverage Δ
unittests 92.40% <76.00%> (-0.51%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@zaxier

zaxier commented Mar 11, 2024

Copy link
Copy Markdown

This feature would assist my use case where a customer wants to be able to arbitrarily group tables into categories (as lists) and apply maintenance jobs based on the category. Different categories will exist side by side each other in any schema and therefore pattern based matching (without restrictive table naming conventions) won't work. A solution would be to use table tags allowing us to use patterns + table tags and keep the convenience and functionality of discoverx to operate over lists of tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants