fix(graph): avoid logging GraphQL query contents in execute_graphql#17231
Open
Anshul759 wants to merge 1 commit intodatahub-project:masterfrom
Open
fix(graph): avoid logging GraphQL query contents in execute_graphql#17231Anshul759 wants to merge 1 commit intodatahub-project:masterfrom
Anshul759 wants to merge 1 commit intodatahub-project:masterfrom
Conversation
Fix Secure Code Vulnerability
github-actions
Bot
added
ingestion
Contributor
|
Linear: ING-2487 Thanks for your contribution! We have created an internal ticket to track this PR. A member of the core DataHub team will be assigned to review it within the next few business days - you will get a follow-up comment once a reviewer is assigned. |
Anshul759
changed the title
maggiehays
added
the
needs-review
Bundle ReportBundle size has no change ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes clear-text GraphQL query logging from execute_graphql in metadata-ingestion/src/datahub/ingestion/graph/client.py.
Previously, the debug log included the full query string. In some cases, GraphQL queries can contain inline sensitive values, which means secrets could be written to logs in clear text. This reduces the risk of leaking sensitive information through application logs while preserving useful debugging metadata.
This is a low-risk security hardening change that prevents accidental secret exposure in logs.