fix(ingestV2): secret deletion always removes last secret instead of …#17237
Open
Itsdarkhere wants to merge 1 commit intodatahub-project:masterfrom
Open
fix(ingestV2): secret deletion always removes last secret instead of …#17237Itsdarkhere wants to merge 1 commit intodatahub-project:masterfrom
Itsdarkhere wants to merge 1 commit intodatahub-project:masterfrom
Conversation
…selected ConfirmationModal was rendered inside the per-row table column renderer, sharing a single boolean `showConfirmDelete` state. When any delete button was clicked all rows' modals opened simultaneously, and confirming always triggered the last row's handleConfirm closure, deleting the wrong secret. Fix tracks the pending-deletion URN in `deletingSecretUrn: string | null` and renders a single ConfirmationModal at the component root.
github-actions
Bot
added
product
Contributor
|
Linear: CAT-1924 Thanks for your contribution! We have created an internal ticket to track this PR. A member of the core DataHub team will be assigned to review it within the next few business days - you will get a follow-up comment once a reviewer is assigned. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
indeed, deleting wrong secrets is concerning 😅 |
maggiehays
added
the
pending-submitter-response
Contributor
sakethvarma397
left a comment
sakethvarma397
left a comment
There was a problem hiding this comment.
This is already fixed in the cloud version, and it seems like it's not added here. To avoid conflicts, it's better that we back port those changes instead of merging this commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…selected
ConfirmationModal was rendered inside the per-row table column renderer, sharing a single boolean
showConfirmDeletestate. When any delete button was clicked all rows' modals opened simultaneously, and confirming always triggered the last row's handleConfirm closure, deleting the wrong secret. Fix tracks the pending-deletion URN indeletingSecretUrn: string | nulland renders a single ConfirmationModal at the component root.