Add face keypoints/animal pose ops & Extend ops for frame-sequence input#966
Open
Qirui-jiao wants to merge 2 commits intomainfrom
Open
Add face keypoints/animal pose ops & Extend ops for frame-sequence input#966Qirui-jiao wants to merge 2 commits intomainfrom
Qirui-jiao wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces two new video mappers, VideoAnimalPoseMapper and VideoFaceKeypointsMapper, for detecting animal poses and face keypoints, respectively. It also updates several existing video mappers to support input from pre-extracted frames. The review feedback identifies several critical issues, including an AttributeError in the animal pose mapper, a missing comma in a category list, and incorrect return types in multiple mappers that would break the processing pipeline. Additionally, there are suggestions to simplify video name extraction and improve the robustness of path handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ops:
video_animal_pose_mapper: Detect quadruped animal pose on the video with ViTPose.video_face_keypoints_mapper: Detect face keypoints (98 points) on the video with LDEQ_RwR.Enable existing ops to support frame-sequence input:
video_camera_calibration_static_moge_mappervideo_depth_estimation_mappervideo_hand_reconstruction_hawor_mappervideo_whole_body_pose_estimation_mapper