Add normal map op, optimal flow op, and universal segmentation op for videos.#970
Open
Qirui-jiao wants to merge 3 commits intomainfrom
Open
Add normal map op, optimal flow op, and universal segmentation op for videos.#970Qirui-jiao wants to merge 3 commits intomainfrom
Qirui-jiao wants to merge 3 commits intomainfrom
Conversation
Qirui-jiao
added
enhancement
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces three new video processing mappers—VideoNormalMapMapper, VideoOpticalFlowMapper, and VideoUniversalSegmentationMapper—along with configuration updates, model utilities, and unit tests. The review feedback highlights critical serialization issues caused by storing raw numpy arrays and torch tensors in metadata, which would break JSON exports. Other feedback addresses a color space bug in the optical flow mapper, fragile path parsing for video names, and the use of an incorrect package version and hardcoded mirror in the segmentation mapper.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ops:
video_normal_map_mapper: Generate normal maps for videos (with the Metric3D model).video_optical_flow_mapper: Generate optical flow information for videos.video_universal_segmentation_mapper: Generate semantic segmentation, instance segmentation, and panoptic segmentation information for videos (with the OneFormer model).