Skip to content

Cross layer overlapping for domino#7178

Merged
tjruwase merged 2 commits into
masterfrom
hongwei_domino_cross_layer_overlap
Mar 28, 2025
Merged

Cross layer overlapping for domino#7178
tjruwase merged 2 commits into
masterfrom
hongwei_domino_cross_layer_overlap

Conversation

@hwchen2017
Copy link
Copy Markdown
Contributor

  1. Add implementation for cross layer communication overlapping to achieve communication "free".
  2. Optimize the implementation for communication overlapping within transformer layer.

Signed-off-by: Hongwei Chen <hongweichen@microsoft.com>
@hwchen2017 hwchen2017 requested a review from tjruwase March 27, 2025 00:59
@hwchen2017 hwchen2017 requested a review from GuanhuaWang as a code owner March 27, 2025 00:59
@tjruwase tjruwase added this pull request to the merge queue Mar 28, 2025
Merged via the queue into master with commit f355b9e Mar 28, 2025
@tjruwase tjruwase deleted the hongwei_domino_cross_layer_overlap branch March 28, 2025 22:21
deepcharm pushed a commit to deepcharm/DeepSpeed that referenced this pull request Mar 31, 2025
1. Add implementation for cross layer communication overlapping to
achieve communication "free".
2. Optimize the implementation for communication overlapping within
transformer layer.

Signed-off-by: Hongwei Chen <hongweichen@microsoft.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Signed-off-by: Max Kovalenko <mkovalenko@habana.ai>
ys950902 pushed a commit to ys950902/DeepSpeed that referenced this pull request May 21, 2025
1. Add implementation for cross layer communication overlapping to
achieve communication "free".
2. Optimize the implementation for communication overlapping within
transformer layer.

Signed-off-by: Hongwei Chen <hongweichen@microsoft.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Signed-off-by: yisheng <yi.sheng@intel.com>
@xmty777
Copy link
Copy Markdown

xmty777 commented Jun 6, 2025

Hi, is there any example for this new feature?
It seems that the Domino example in DeepSpeedExamples haven’t been updated yet, and there are some conflicts as well.
Would you mind providing an updated example or sharing some guidance on how to use this feature? Thanks!

@hwchen2017
Copy link
Copy Markdown
Contributor Author

Hi @xmty777 , I will update the deepspeed example and let you know.

@hwchen2017
Copy link
Copy Markdown
Contributor Author

Hi @xmty777 , the Domino example in DeepSpeedExamples has been updated.

deepcharm pushed a commit to deepcharm/DeepSpeed that referenced this pull request Jun 16, 2025
1. Add implementation for cross layer communication overlapping to
achieve communication "free".
2. Optimize the implementation for communication overlapping within
transformer layer.

Signed-off-by: Hongwei Chen <hongweichen@microsoft.com>
Co-authored-by: Logan Adams <114770087+loadams@users.noreply.github.com>
Signed-off-by: Max Kovalenko <mkovalenko@habana.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants