Skip to content

Added deepProp, deepTheme, and deepPalette#59

Open
jtmthf wants to merge 19 commits into
diegohaz:masterfrom
jtmthf:deep
Open

Added deepProp, deepTheme, and deepPalette#59
jtmthf wants to merge 19 commits into
diegohaz:masterfrom
jtmthf:deep

Conversation

@jtmthf

@jtmthf jtmthf commented Jan 30, 2019

Copy link
Copy Markdown
Collaborator

Re-closes #55. Adds deepProp, deepTheme, and deepPalette.

@diegohaz diegohaz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @jtmthf. I made a few suggestions (a yarn lint --fix may be needed after applying them).

Also, I was thinking about, instead of separate functions, a single function resolvePaletteProps that would return { key, tone, defaultValue } and then used as:

const { key, tone, defaultValue: finalDefaultValue } = resolvePaletteProps(...);

Comment thread src/deepPalette.js Outdated
Comment thread src/deepPalette.js Outdated
Comment thread src/deepPalette.js Outdated
Comment thread src/deepPalette.js Outdated
Comment thread src/deepPalette.js Outdated
Comment thread src/utils.js Outdated
Comment thread src/utils.js Outdated
Comment thread src/utils.js Outdated
Comment thread src/utils.js Outdated
Comment thread src/utils.js Outdated
jtmthf and others added 17 commits April 25, 2020 11:26
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
Co-Authored-By: Haz <hazdiego@gmail.com>
@jtmthf

jtmthf commented Apr 25, 2020

Copy link
Copy Markdown
Collaborator Author

@diegohaz I recently had a use for this project and I forgot that I still had this PR open. I applied your suggestions and cleaned a few things up if you're still interested in this feature.

@exports

exports commented May 25, 2020

Copy link
Copy Markdown

I'm looking forward the new feature to solve my recent problems, will this be merged?

@iamgbayer

Copy link
Copy Markdown

is there something else needed to merge this pr?

@alvarogfn

Copy link
Copy Markdown

Hey, @jtmthf

Please, can you open this PR on my fork?

https://github.com/alvarogfn/styled-bettertools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Needles should be recursively resolved

5 participants