Skip to content

refactor: modularize imageGeneration.ts (rebased onto v3.8.31)#4407

Closed
oyi77 wants to merge 1 commit into
diegosouzapw:release/v3.8.34from
oyi77:pr/image-generation
Closed

refactor: modularize imageGeneration.ts (rebased onto v3.8.31)#4407
oyi77 wants to merge 1 commit into
diegosouzapw:release/v3.8.34from
oyi77:pr/image-generation

Conversation

@oyi77

@oyi77 oyi77 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Rebased version of #3991 onto upstream/release/v3.8.31.

Extracts the 3776-line open-sse/handlers/imageGeneration.ts monolith into 23 focused modules:

  • blackForestLabs, chatgptWeb, codex, core, fal, gemini, imagen3, kie
  • logging, openai, stability, utils
  • specialty/ (comfyui, haiper, hyperbolic, ideogram, leonardo, nanobanana, recraft, sdwebui, topaz)
  • index.ts (barrel)

Oversized specialty.ts (1207 lines) sub-split into 8 focused files.
Original file replaced with thin re-export. Lossless extraction.

Replaces: #3991 (was based on older release)

@oyi77 oyi77 requested a review from diegosouzapw as a code owner June 20, 2026 16:11
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@oyi77

oyi77 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor Author

Replaces closed PR (original was held pending quality-gate landing). Quality gates are now stable through v3.8.31 — reopening for merge. Related: #3594

@diegosouzapw diegosouzapw changed the base branch from release/v3.8.31 to release/v3.8.32 June 20, 2026 18:30
@oyi77 oyi77 force-pushed the pr/image-generation branch 2 times, most recently from 5a7bcef to 9f3a509 Compare June 20, 2026 18:42
@oyi77 oyi77 force-pushed the pr/image-generation branch from 9f3a509 to 307693d Compare June 20, 2026 22:50
@diegosouzapw diegosouzapw changed the base branch from release/v3.8.32 to release/v3.8.33 June 21, 2026 14:03
@oyi77 oyi77 force-pushed the pr/image-generation branch 4 times, most recently from dedaaec to 287102f Compare June 22, 2026 06:29
@oyi77 oyi77 force-pushed the pr/image-generation branch from 287102f to 903a903 Compare June 22, 2026 06:40
@diegosouzapw diegosouzapw changed the base branch from release/v3.8.33 to release/v3.8.34 June 22, 2026 07:39
@oyi77

oyi77 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #4706 — rebased onto release/v3.8.34, all CI gates pass.

@oyi77 oyi77 closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant