#1636 - Remove deprecated APIs for 3.0.0#1637
Merged
Merged
Conversation
- Remove deprecated SerializedCasReader and SerializedCasWriter (io-bincas), superseded by BinaryCasReader / BinaryCasWriter
- Migrate serialized-format test coverage to BinaryCasWriter (format S+ for embedded type system, S for separate type system)
- Fix stale {@link SerializedCasReader} javadoc reference in BinaryCasWriter
- Remove deprecated LineBasedSentenceSegmenter and WhitespaceSegmenter (tokit), superseded by RegexSegmenter
- Remove the dedicated tests for the removed classes (SerializedCasWriterReaderTest, LineBasedSentenceSegmenterTest, WhitespaceSegmenterTest)
- Remove deprecated ResourceCollectionReaderBase.PARAM_PATH (use PARAM_SOURCE_LOCATION) - Remove deprecated ResourceMetadata.META_ENCODING (use META_MODEL_ENCODING) - Remove deprecated ResourceUtils.resolveCompressedInputStream (use CompressionUtils.getInputStream) - Remove deprecated SegmenterBase.createToken(JCas, int, int, int) overload (use createToken(JCas, int, int)) - Remove deprecated TfIdfWriter.PARAM_OUTPUT_PATH (use PARAM_TARGET_LOCATION) - Remove deprecated AssertAnnotations.assertMorpheme (use assertMorph) and assertSemanticPredicates (use assertSemPred), plus now-unused imports
reckart
changed the title
- Remove deprecated DataPackage and DatasetLoader (api-datasets), superseded by DatasetFactory; drop the disabled DatasetLoaderTest - Remove deprecated text normalizer framework (textnormalizer): Normalizer_ImplBase, ReplacementFileNormalizer, NormalizerFactory, internal AnnotationComparator, and their tests - Move dkpro-core-tokit-asl and dkpro-core-jazzy-asl to test scope in textnormalizer (only used by tests after the removals) - Move commons-io to test scope in io-bincas (only used by tests after removing SerializedCasReader/Writer)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation