Skip to content

fix docker build#2015

Merged
m-1-k-3 merged 3 commits into
e-m-b-a:masterfrom
m-1-k-3:actions
Jun 16, 2026
Merged

fix docker build#2015
m-1-k-3 merged 3 commits into
e-m-b-a:masterfrom
m-1-k-3:actions

Conversation

@m-1-k-3

@m-1-k-3 m-1-k-3 commented Jun 16, 2026

Copy link
Copy Markdown
Member
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Bug fix

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Copilot AI review requested due to automatic review settings June 16, 2026 06:31
@m-1-k-3 m-1-k-3 added bug Something isn't working docker docker related things EMBA dependencies Pull requests that update a dependency file labels Jun 16, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the IF50_aggregator_common.sh installer script to set the HOMEBREW_NO_SANDBOX_LINUX=1 environment variable when installing cyclonedx-cli via Homebrew. The review feedback highlights a lack of error handling for the installation command and points out that the existing error handling in surrounding lines uses subshells, which prevents the main script from exiting on failure. A code suggestion is provided to address these issues using curly braces.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread installer/IF50_aggregator_common.sh Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to fix a Docker build issue by adjusting how cyclonedx-cli is installed via Linuxbrew during the installer flow.

Changes:

  • Disable Homebrew’s Linux sandbox during cyclonedx-cli installation by setting HOMEBREW_NO_SANDBOX_LINUX=1.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread installer/IF50_aggregator_common.sh
@m-1-k-3 m-1-k-3 merged commit 59fc0b4 into e-m-b-a:master Jun 16, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file docker docker related things EMBA

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants