Fix return type of the for_user method#179
Open
mgax wants to merge 2 commits into
Open
Conversation
mgax
commented
Jun 25, 2026
| from .token_blacklist.models import BlacklistedToken, OutstandingToken | ||
| from .utils import aware_utcnow, datetime_from_epoch, datetime_to_epoch, format_lazy | ||
|
|
||
| T = TypeVar("T", bound="Token") |
Author
There was a problem hiding this comment.
I tried to use typing.Self at first but it was only introduced in Python 3.11 and the testsuite checks against older Pythons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
for_userclassmethod returns an instance ofcls(), but it claims to returnToken:django-ninja-jwt/ninja_jwt/tokens.py
Lines 183 to 184 in b419409
To get the access token from
RefreshToken.for_user, one has to cast the return value in order to make the type checker happy:This PR removes the need for that cast by annotating
for_userto returnSelf, which may beToken, or the subclass.