[#1742] Implement ros2 tunnel send path#1744
Conversation
c762fab to
b7b0aa2
Compare
b7b0aa2 to
13be5b9
Compare
13be5b9 to
eeb8956
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1744 +/- ##
==========================================
- Coverage 76.25% 76.21% -0.05%
==========================================
Files 430 429 -1
Lines 42701 42684 -17
Branches 1327 1329 +2
==========================================
- Hits 32562 32530 -32
- Misses 9054 9066 +12
- Partials 1085 1088 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
…counted NodeInner
726b851 to
9db0a7e
Compare
| /// | ||
| /// The handle points into the loaded library's memory, so the `Library` is | ||
| /// kept alive here; it stays loaded as long as any clone is alive. | ||
| #[derive(Debug, Clone)] |
There was a problem hiding this comment.
Please do not implement Clone for a shallow clone.
In my opinion, it is cleaner when everyone, who requires the type support to be alive uses the Rc<TypeSupportInner> struct. Otherwise, one might think that two distinct TypeSupport instances are alive whilst there is just one.
There was a problem hiding this comment.
@elfenpiff I don't really follow your point. This is just a "handle to the type support".
There was a problem hiding this comment.
Since we have two different views here, could we agree that @elBoberido solves the tie?
There was a problem hiding this comment.
This is just a minimal wrapper of rcl only for use by the tunnel. Is it worth to spend more time here? We can change it later.
There was a problem hiding this comment.
A little bit late to the party, but I would also prefer to have a Rc<TypeSupportInner>/Rc<TypeSupport> instead of hiding the Rc in a wrapper.
There was a problem hiding this comment.
@elBoberido @elfenpiff I will revise it all later, let me get the functionality in, then I will do some additional iterations to make it pretty and conventional. I cannot do both at once 🫠 .
5523dbc to
961d184
Compare
Notes for Reviewer
Implements the send path for the ROS 2 tunnel backend.
Remaining capabilities and CI to be merged in subsequent pull requests. See the README in
integrations/ros2/tunnel-backendfor the development status.Pre-Review Checklist for the PR Author
Convert to draft)iox2-123-introduce-posix-ipc-example)[#123] Add posix ipc example)Tests follow the best practice for testingChangelog updated in the unreleased section including API breaking changesPR Reviewer Reminders
References
Closes #1742