Conversation
VectorDB Benchmark — Dense — PassedTriggered by @omnish-endee · Commit
|
|
/correctness_benchmarking dense |
3 similar comments
|
/correctness_benchmarking dense |
|
/correctness_benchmarking dense |
|
/correctness_benchmarking dense |
VectorDB Benchmark - Ready To Run
Post one of the command below. Only members with write access can trigger runs. Available Modes
Infrastructure
Both servers start on demand and are always terminated after the run — pass or fail. How Correctness Benchmarking Works
|
|
/correctness_benchmarking dense |
VectorDB Benchmark — Dense — FailedTriggered by @hemant-endee · Commit
|
| struct RebuildResult { | ||
| bool success; | ||
| int http_code; | ||
| std::string message; | ||
| }; | ||
|
|
There was a problem hiding this comment.
use unsigned char and std::string. declare a generic return struct which will be used everywhere in the codebase eventually.
for each function returning this struct, at the comments above the function definition will define what each return code means. This can be later conglomerated as ENUMS.
| int code = (message.find("already in progress") != std::string::npos) ? 409 : 400; | ||
| return json_error(code, message); | ||
| if (!result.success) { | ||
| return json_error(result.http_code, result.message); |
There was a problem hiding this comment.
do not couple http codes to the core source. decide the http_code to be returned based on the return code of the function,.
There was a problem hiding this comment.
dont use atomics in status variables
There was a problem hiding this comment.
remove jthread from here
There was a problem hiding this comment.
dont use string comparisons for this.
| } catch (const std::exception&) { | ||
| // Silently ignore cleanup errors on startup | ||
| } catch (const std::exception& e) { | ||
| LOG_WARN(2053, "rebuild", "Failed to cleanup temp files on startup: " << e.what()); |
There was a problem hiding this comment.
use 1800 series for rebuild logs. add it to docs/logs.md
* Rebuild index with new config * fix 1 * index name in get stattu api correction * docs changes * Rebuild Status Persistence
…me as addVectors)
hemant-endee
force-pushed
the
hemant/rebuild_updated
branch
from
117a81f to
6f4083e
Compare
…y + IndexManager to executeJob instead of unpacking fields
3 participants
No description provided.