Add missing mcp-client.mjs to services directory#4
Open
yourfriendfitz wants to merge 1 commit intoengindearing-projects:mainfrom
Open
Add missing mcp-client.mjs to services directory#4yourfriendfitz wants to merge 1 commit intoengindearing-projects:mainfrom
yourfriendfitz wants to merge 1 commit intoengindearing-projects:mainfrom
Conversation
The MCP client module was missing from services/, causing the gateway to crash on startup with "Cannot find module './mcp-client.mjs'". This file is imported by tools.mjs and claude-sessions.mjs. Closes engindearing-projects#3 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp-client.mjsmodule toservices/, which is imported bytools.mjsandclaude-sessions.mjsCannot find module './mcp-client.mjs'Additional context
This is part of the fix for #3. The gateway crash was caused by two issues:
services/mcp-client.mjswas never committed (fixed by this PR)apps/cli/directory structure intolibexec/, breaking relative imports that reference../../../../shared/or../apps/cli/lib/. The formula atengindearing-projects/homebrew-tapneeds a separate fix to either:apps/cli/directory prefix inlibexec/Homebrew formula fix needed (separate PR to
homebrew-tap)The current formula does:
This should instead preserve the monorepo path:
And update the wrapper script to point at the correct entry:
Test plan
familiar doctor— gateway should start without module errorsfamiliar status— all services healthyfamiliar— TUI launchesCloses #3
🤖 Generated with Claude Code