Refactor epicshop into workshop-cli package by kentcdodds · Pull Request #252 · epicweb-dev/epicshop

kentcdodds · 2025-07-03T12:25:28Z

This pull request contains changes generated by Cursor background composer.

…rithm for workshop-app - Add colors back to interactive keys display in yargs epilogue - Use import.meta.resolve() for finding workshop-app package instead of manual path resolution - Update example/epicshop/package.json to include @epic-web/workshop-cli dependency - Fixes GitHub Actions playwright tests that were failing due to missing CLI

cursor

Bug: Handler Overwrite Causes Shutdown Issues

Multiple closeWithGrace handlers are registered. The new error logging handler (lines 26-30) is overwritten by later cleanup handlers. This occurs because the closeWithGrace library only maintains one active handler, with subsequent calls replacing previous ones. As a result, the early error logging will not function, and overall application shutdown behavior may be unpredictable or incomplete.

packages/workshop-app/server/index.ts#L25-L30

epicshop/packages/workshop-app/server/index.ts

Lines 25 to 30 in 0ccba66

    
           // if we exit early with an error, log the error... 
        
           closeWithGrace(({ err, manual }) => { 
        
           	if (manual) return 
        
           	if (err) console.error(err.stack) 
        
           })

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

nx-cloud · 2025-09-23T04:24:16Z

View your CI Pipeline Execution ↗ for commit 0ccba66

Command	Status	Duration	Result
`nx run-many --target build`	✅ Succeeded	2s	View ↗
`nx run-many --target typecheck`	✅ Succeeded	<1s	View ↗
`nx lint`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2025-09-23 04:53:10 UTC

kentcdodds force-pushed the cursor/refactor-epicshop-into-workshop-cli-package-0b1e branch from 5590f2d to 902882e Compare July 3, 2025 17:40

This comment was marked as outdated.

Sign in to view

kentcdodds force-pushed the cursor/refactor-epicshop-into-workshop-cli-package-0b1e branch from 8c5e6aa to 3342e17 Compare July 5, 2025 20:02

This comment was marked as outdated.

Sign in to view

kentcdodds force-pushed the cursor/refactor-epicshop-into-workshop-cli-package-0b1e branch from 1870474 to e341d69 Compare July 5, 2025 21:14

This comment was marked as outdated.

Sign in to view

cursoragent and others added 19 commits July 5, 2025 20:38

Changes from background composer bc-e8f9ca68-13d1-4f01-b286-17e81bbb5ca3

937cb2d

Checkpoint before follow-up message

84cc563

Checkpoint before follow-up message

0b1c55a

Checkpoint before follow-up message

dd96df5

fix epicshop reference

23353a1

add cli to tsconfig.json

2715e91

cleanup some things

b22bec0

improve message output

6da191c

fix start for example

560b5a6

this is probably more correct

736b635

flush-npm

9ea2a4d

we need to build first

b0bc5df

add setup script

e2b2b0e

build again

981eabb

add dep

c3c40b5

improve relative path resolution

af7826f

try building again

c9eb48c

fix build artifact upload

a867cf6

kentcdodds added 2 commits July 5, 2025 20:38

add bin to build artifacts

057f2d9

rebuild

bad7e10

kentcdodds force-pushed the cursor/refactor-epicshop-into-workshop-cli-package-0b1e branch from db583e1 to bad7e10 Compare July 6, 2025 02:41

This comment was marked as outdated.

Sign in to view

kentcdodds added 2 commits July 5, 2025 20:52

pretty sure this will work now

bae79d9

add log

23ef15b

This comment was marked as outdated.

Sign in to view

kentcdodds added 4 commits July 5, 2025 21:05

more logs

686b038

oh boy

f7f61b8

crazy stuff

4f01b7b

never fail

ddfb3a1

This comment was marked as outdated.

Sign in to view

kentcdodds added 3 commits July 5, 2025 21:20

this will work maybe

adbad38

downloading artifacts should happen before install

a4a0d75

whoops

0ccba66

cursor Bot reviewed Jul 6, 2025

View reviewed changes

kentcdodds merged commit b506c08 into main Jul 6, 2025
9 checks passed

kentcdodds deleted the cursor/refactor-epicshop-into-workshop-cli-package-0b1e branch July 6, 2025 03:30


	// if we exit early with an error, log the error...
	closeWithGrace(({ err, manual }) => {
	if (manual) return
	if (err) console.error(err.stack)
	})

Conversation

kentcdodds commented Jul 3, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Handler Overwrite Causes Shutdown Issues

Uh oh!

Uh oh!

nx-cloud Bot commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nx-cloud Bot commented Sep 23, 2025 •

edited

Loading