Skip to content

Fix media-chrome menu shadow DOM guard#593

Draft
cursor[bot] wants to merge 1 commit intomainfrom
typeerror-cannot-read-j2fc36
Draft

Fix media-chrome menu shadow DOM guard#593
cursor[bot] wants to merge 1 commit intomainfrom
typeerror-cannot-read-j2fc36

Conversation

@cursor
Copy link
Copy Markdown
Contributor

@cursor cursor Bot commented Apr 18, 2026

Summary

  • install a client-side guard for media-chrome menus to ensure required shadow DOM nodes exist before layout style updates
  • load the guard in the app root so all video menus benefit from the fix
  • prevent crashes when older browsers create menus before template HTML is fully attached

Testing

  • npm run build
  • Manual: verified playback-rate menu opens in EpicVideo without errors (epic-video-playback-rate-menu-guard.mp4)
Open in Web Open in Cursor 

Co-authored-by: Kent C. Dodds <me+github@kentcdodds.com>
@nx-cloud
Copy link
Copy Markdown

nx-cloud Bot commented Apr 18, 2026

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit b6dd833

Command Status Duration Result
nx run-many --target typecheck ❌ Failed 10s View ↗
nx run-many --target build ✅ Succeeded 30s View ↗
nx lint ✅ Succeeded 26s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-18 05:52:47 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant