Skip to content

fix: add is_base_form to FrenchLemmatizer to prevent over-lemmatizing infinitives #13965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RudrenduPaul wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −0
Open

fix: add is_base_form to FrenchLemmatizer to prevent over-lemmatizing infinitives #13965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spacy/lang/fr/lemmatizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ class FrenchLemmatizer(Lemmatizer):
the lookup table.
"""

def is_base_form(self, token: Token) -> bool:
"""Check whether the token is already in base form so that suffix
rules are skipped. French infinitives (VerbForm=Inf) are already in
base form; applying further suffix rules to them produces incorrect
results (e.g. "descendre" → "descendrer").
"""
return token.morph.to_dict().get("VerbForm") == "Inf"

@classmethod
def get_lookups_config(cls, mode: str) -> Tuple[List[str], List[str]]:
if mode == "rule":
Expand All @@ -30,6 +38,8 @@ def rule_lemmatize(self, token: Token) -> List[str]:
univ_pos = token.pos_.lower()
if univ_pos in ("", "eol", "space"):
return [string.lower()]
if self.is_base_form(token):
return [string.lower()]
elif "lemma_rules" not in self.lookups or univ_pos not in (
"noun",
"verb",
Expand Down