Skip to content

Add backdrop.color to libf3d and a f3d option#2989

Merged
mwestphal merged 27 commits into
f3d-app:masterfrom
PedroAbreuMaia:Add-backdrop.color-libf3d-and-F3D-option
May 14, 2026
Merged

Add backdrop.color to libf3d and a f3d option#2989
mwestphal merged 27 commits into
f3d-app:masterfrom
PedroAbreuMaia:Add-backdrop.color-libf3d-and-F3D-option

Conversation

@PedroAbreuMaia
Copy link
Copy Markdown
Contributor

@PedroAbreuMaia PedroAbreuMaia commented Mar 30, 2026

Describe your changes

  • Added libf3d option ui.backdrop.color option to control backdrop color.
  • Added a CLI option to control it --backdrop-color.
  • This option is set black by default.
  • Added new tests.

Issue ticket number and link if any

#2861

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@mwestphal mwestphal self-requested a review March 30, 2026 11:28
@mwestphal
Copy link
Copy Markdown
Member

thanks, ill review later today.

Comment thread library/src/window_impl.cxx Outdated
Comment thread vtkext/private/module/vtkF3DRenderer.cxx
Comment thread vtkext/private/module/vtkF3DRenderer.h Outdated
Comment thread vtkext/private/module/vtkF3DUIActor.cxx
Comment thread vtkext/private/module/vtkF3DUIActor.h
Comment thread vtkext/private/module/vtkF3DUIActor.h
Comment thread resources/cli-options.json
Comment thread library/options.json
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes needed

@mwestphal
Copy link
Copy Markdown
Member

  • Please resolve discussions if you've adressed them, instead of commenting "Done" :)
  • Please avoid merging with master, instead use rebase, and only if needed.

Comment thread vtkext/private/module/vtkF3DUIActor.h Outdated
@mwestphal mwestphal marked this pull request as ready for review March 31, 2026 15:55
@mwestphal
Copy link
Copy Markdown
Member

\ci fast

Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last small change, I've also run CI :)

@mwestphal mwestphal self-requested a review March 31, 2026 16:01
@PedroAbreuMaia
Copy link
Copy Markdown
Contributor Author

\ci fast

Comment thread library/options.json Outdated
@PedroAbreuMaia PedroAbreuMaia requested a review from mwestphal April 2, 2026 13:48
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lets check CI

@mwestphal
Copy link
Copy Markdown
Member

\ci full

@mwestphal mwestphal self-requested a review April 3, 2026 05:58
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is breaking many tests, it must be changing the default behavior of f3d, which we do not want. Please take a look :)

@mwestphal mwestphal self-requested a review April 5, 2026 06:44
Comment thread library/options.json Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.15%. Comparing base (d16ba95) to head (5da934b).
⚠️ Report is 23 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2989      +/-   ##
==========================================
+ Coverage   97.12%   97.15%   +0.02%     
==========================================
  Files         208      211       +3     
  Lines       16695    17206     +511     
==========================================
+ Hits        16215    16716     +501     
- Misses        480      490      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@PedroAbreuMaia PedroAbreuMaia force-pushed the Add-backdrop.color-libf3d-and-F3D-option branch from faa5d02 to a54d338 Compare May 6, 2026 00:18
PedroAbreuMaia and others added 4 commits May 5, 2026 21:18
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
@PedroAbreuMaia PedroAbreuMaia requested a review from mwestphal May 6, 2026 02:15
@mwestphal
Copy link
Copy Markdown
Member

Please note the CI failure is not related and caused by a github issue.

Comment thread doc/libf3d/03-OPTIONS.md
Comment thread doc/user/03-OPTIONS.md Outdated
Comment thread doc/libf3d/03-OPTIONS.md Outdated
Comment thread library/options.json Outdated
Comment thread vtkext/private/module/vtkF3DUIActor.h Outdated
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there :)

PedroAbreuMaia and others added 4 commits May 6, 2026 08:27
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
@PedroAbreuMaia PedroAbreuMaia requested a review from mwestphal May 11, 2026 15:00
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about default value

@PedroAbreuMaia PedroAbreuMaia requested a review from mwestphal May 11, 2026 17:50
@PedroAbreuMaia PedroAbreuMaia requested a review from a team as a code owner May 12, 2026 22:31
Comment thread vtkext/private/module/vtkF3DUIActor.h Outdated
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last doc change

Co-authored-by: Mathieu Westphal <mwestphal.f3d@protonmail.com>
@PedroAbreuMaia PedroAbreuMaia requested a review from mwestphal May 13, 2026 14:50
@mwestphal mwestphal merged commit 009f5a2 into f3d-app:master May 14, 2026
53 checks passed
@mwestphal
Copy link
Copy Markdown
Member

Thanks for the contribution @PedroAbreuMaia !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants