Skip to content

Move user event loop callback to it's own API#3115

Merged
Meakk merged 13 commits into
f3d-app:masterfrom
Meakk:mesh-class-1
May 7, 2026
Merged

Move user event loop callback to it's own API#3115
Meakk merged 13 commits into
f3d-app:masterfrom
Meakk:mesh-class-1

Conversation

@Meakk
Copy link
Copy Markdown
Member

@Meakk Meakk commented May 5, 2026

Describe your changes

Needed for #3051

At the moment, when using triggerEventLoop() manually there's no way to specify the user callback.
It would also be odd to pass the user callback each time we want to trigger the event loop manually, so let's move it to its own API so the user can set it once.

Also added a documentation for migration to 4.0.

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
  • ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Meakk Meakk self-assigned this May 5, 2026
@Meakk Meakk added the ci:fast label May 5, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

You are modifying libf3d public API! ⚠️Please update bindings accordingly⚠️!
You can find them in their respective directories: c, python, java, webassembly.

@Meakk Meakk added ci:full and removed ci:fast labels May 5, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.06%. Comparing base (12a0ede) to head (141a18a).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3115      +/-   ##
==========================================
- Coverage   97.12%   97.06%   -0.06%     
==========================================
  Files         208      208              
  Lines       16705    16717      +12     
==========================================
+ Hits        16225    16227       +2     
- Misses        480      490      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread library/testing/TestSDKSceneFromMemory.cxx
Comment thread library/public/interactor.h Outdated
@Meakk Meakk requested a review from mwestphal May 5, 2026 15:23
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing in javascript bindings I suppose ?

Comment thread library/public/interactor.h
Comment thread library/testing/TestSDKSceneFromMemory.cxx
Comment thread doc/libf3d/01-OVERVIEW.md Outdated
Comment thread doc/libf3d/06-MIGRATION.md Outdated
Comment thread doc/libf3d/06-MIGRATION.md Outdated
Meakk and others added 3 commits May 6, 2026 08:33
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: snoyer <noyer.stephane@gmail.com>
@Meakk Meakk requested review from mwestphal and snoyer May 6, 2026 06:33
Comment thread doc/libf3d/01-OVERVIEW.md Outdated
Comment thread doc/libf3d/06-MIGRATION.md Outdated
Copy link
Copy Markdown
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small last change

@Meakk Meakk requested a review from mwestphal May 7, 2026 07:10
@Meakk
Copy link
Copy Markdown
Member Author

Meakk commented May 7, 2026

Windows CI broken, not related, merging

@Meakk Meakk merged commit 6657154 into f3d-app:master May 7, 2026
57 of 63 checks passed
@Meakk Meakk deleted the mesh-class-1 branch May 7, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants