Move user event loop callback to it's own API#3115
Merged
Conversation
|
You are modifying libf3d public API! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3115 +/- ##
==========================================
- Coverage 97.12% 97.06% -0.06%
==========================================
Files 208 208
Lines 16705 16717 +12
==========================================
+ Hits 16225 16227 +2
- Misses 480 490 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Meakk
commented
May 5, 2026
snoyer
reviewed
May 5, 2026
mwestphal
requested changes
May 6, 2026
Member
mwestphal
left a comment
There was a problem hiding this comment.
Looks good, nothing in javascript bindings I suppose ?
snoyer
reviewed
May 6, 2026
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: Mathieu Westphal <mathieu.westphal@gmail.com>
Co-authored-by: snoyer <noyer.stephane@gmail.com>
Meakk
commented
May 6, 2026
mwestphal
reviewed
May 7, 2026
mwestphal
approved these changes
May 7, 2026
Member
Author
|
Windows CI broken, not related, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Needed for #3051
At the moment, when using
triggerEventLoop()manually there's no way to specify the user callback.It would also be odd to pass the user callback each time we want to trigger the event loop manually, so let's move it to its own API so the user can set it once.
Also added a documentation for migration to 4.0.
Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampAI Disclosure
Continuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.