Skip to content

Fix OBJ unlit color space#3147

Merged
Meakk merged 2 commits into
f3d-app:masterfrom
Meakk:fix-obj-unlit
May 14, 2026
Merged

Fix OBJ unlit color space#3147
Meakk merged 2 commits into
f3d-app:masterfrom
Meakk:fix-obj-unlit

Conversation

@Meakk
Copy link
Copy Markdown
Member

@Meakk Meakk commented May 13, 2026

Describe your changes

Fixed issue reported here: https://discord.com/channels/1046005690809978911/1503472626625019904

Issue ticket number and link if any

Checklist for finalizing the PR

  • I have performed a self-review of my code
  • I have added tests for new features and bugfixes
  • I have added documentation for new features
  • If it is a modifying the libf3d API, I have updated bindings
  • If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

AI Disclosure

  • I did not use AI to generate any of the content of that pull request
  • I used AI to generate code in that pull request, if yes please disclose which part of the code was generated and with which model.
  • ...

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@Meakk Meakk added the ci:fast label May 13, 2026
@Meakk Meakk self-assigned this May 13, 2026
@Meakk Meakk added ci:main and removed ci:fast labels May 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.20%. Comparing base (0272116) to head (3e66228).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3147   +/-   ##
=======================================
  Coverage   97.19%   97.20%           
=======================================
  Files         211      211           
  Lines       17134    17188   +54     
=======================================
+ Hits        16654    16708   +54     
  Misses        480      480           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Meakk Meakk added ci:full and removed ci:main labels May 13, 2026
@Meakk Meakk marked this pull request as ready for review May 13, 2026 14:37
@Meakk Meakk requested a review from a team as a code owner May 13, 2026 14:37
@Meakk Meakk merged commit 70e3af0 into f3d-app:master May 14, 2026
97 of 99 checks passed
@Meakk Meakk deleted the fix-obj-unlit branch May 14, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants