fix(codex): prefer provider bearer token in form#4692
Open
jzcangshu wants to merge 1 commit into
Open
Conversation
Owner
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary / 概述
auth.jsonOPENAI_API_KEYwhile the active third-party token is stored inconfig.tomlasexperimental_bearer_token.auth.jsonas the source of truth.Related Issue / 关联 Issue
Fixes #4108
Screenshots / 截图
Checklist / 检查清单
pnpm typecheckpasses / 通过 TypeScript 类型检查pnpm format:checkpasses / 通过代码格式检查cargo clippypasses (if Rust code changed) / 通过 Clippy 检查(如修改了 Rust 代码)Test Notes / 测试说明
pnpm --config.allowBuilds.esbuild=true --config.allowBuilds.msw=true vitest run tests/hooks/useCodexConfigState.test.tsx tests/utils/providerConfigUtils.codex.test.ts --reporter=verbose(26 tests).pnpm --config.allowBuilds.esbuild=true --config.allowBuilds.msw=true typecheck.pnpm --config.allowBuilds.esbuild=true --config.allowBuilds.msw=true format:check.git diff --check HEAD^ HEAD.pnpm --config.allowBuilds.esbuild=true --config.allowBuilds.msw=true test:unitcurrently fails in existingtests/integration/App.test.tsxcoverage:covers basic provider flows via real hookstimes out at 5000ms, andshows toast when auto sync fails in backgroundsees duplicateprovider-listDOM nodes after the prior timeout. The targeted Codex regression tests pass, and the failing integration file is unrelated to this form-state change.