fix: accept CAIP-2 EVM network ids in x402-client#14
Conversation
|
Tracked the CI failure down to the new Base bridge assertions. On GitHub Actions, @fastxyz/allset-sdk 0.1.8 exposes Base mainnet under the AllSet mainnet provider namespace, but x402-client was still resolving Base through the testnet namespace, so getBridgeConfig('base') and getBridgeConfig('eip155:8453') returned null in CI.\n\nPushed a fix to resolve Base through the AllSet mainnet namespace and updated the bridge-context test to match. This should unblock the two failing CI jobs on the next run. |
| const chainName = normalizedNetwork === 'ethereum-sepolia' ? 'ethereum-sepolia' | ||
| : normalizedNetwork === 'arbitrum-sepolia' ? 'arbitrum-sepolia' | ||
| : normalizedNetwork === 'base' ? 'base' | ||
| : normalizedNetwork; |
There was a problem hiding this comment.
Should we just use something like const chainName = normalizedNetwork or just use normalizedNetwork directly? I think this code will always equal normalizedNetwork
There was a problem hiding this comment.
Yes. That mapping was redundant; I removed it and now use normalizedNetwork directly in getBridgeConfig.
Summary
Testing
Closes #13