build: tool.setuptools.namespaces = false#5322
Closed
yxtay wants to merge 3 commits into
Closed
Conversation
Signed-off-by: yxtay <5795122+yxtay@users.noreply.github.com>
tool.setuptools.namespaces = false
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
https://setuptools.pypa.io/en/latest/userguide/package_discovery.html#custom-discovery
https://github.com/feast-dev/feast/blob/master/setup.py
Based on the documentation and following the
setup.pythat was based on, thenamespace = falseshould be set in[tool.setuptools]setup.py,find_packageswas used instead offind_namespace_packagesdocsandrequirementsfolder are not errorneously included in the feast packagerequirements.txtfiles in therequirementsfolder is being flagged out to contain vulnerable versions in container scanssdk/python/ui/package.jsonand the Dockerfiles insdk/python/feast/infra/feature_servers/multicloud, but do not have any suggestions yet.sdk/python/uishould not be included in the python package, but I'm not sure what exactly is it's purpose and who uses it right nowWhich issue(s) this PR fixes:
Misc